Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging recorded requests resulted in output of [Object Object] #959

Merged
merged 1 commit into from
Sep 19, 2017

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Aug 25, 2017

observed behavior

Capturing and printing recorded results, using:

nock.recorder.rec({
  output_objects: true
});

resulted in [Object Object] being output to standard out.

Expected Behavior

A serialized JSON object would be output.

@coveralls
Copy link

coveralls commented Aug 25, 2017

Coverage Status

Coverage remained the same at 92.654% when pulling 2911c47 on bcoe:fix-recording into 8da9ee0 on node-nock:master.

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks Ben!

@gr2m gr2m merged commit 97d1ea1 into nock:master Sep 19, 2017
gr2m added a commit that referenced this pull request Sep 21, 2017
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants