Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README.md) - fix info about mocking #971

Merged
merged 1 commit into from
Sep 19, 2017
Merged

docs(README.md) - fix info about mocking #971

merged 1 commit into from
Sep 19, 2017

Conversation

akaguny
Copy link
Contributor

@akaguny akaguny commented Sep 19, 2017

it`s clone #958 because fork of #958 has been deleted

@akaguny
Copy link
Contributor Author

akaguny commented Sep 19, 2017

@gr2m pls review

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 91.834% when pulling 9a16249 on akaguny:docs-readme-fix-info-persist into 978a3f0 on node-nock:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 91.834% when pulling 9a16249 on akaguny:docs-readme-fix-info-persist into 978a3f0 on node-nock:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.664% when pulling 9a16249 on akaguny:docs-readme-fix-info-persist into 978a3f0 on node-nock:master.

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Thanks Alexey

@gr2m gr2m merged commit e911688 into nock:master Sep 19, 2017
@akaguny akaguny deleted the docs-readme-fix-info-persist branch September 19, 2017 06:55
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants