Fix #992 Bind the socket event listener to the request object

[rsimp]

Backport of 50859e5 from 9.0.x to 8.2.x. Fixes compatibility with Axios. Fixes #992.

[rsimp]

Weird the tests all ran fine locally:

[rsimp]

Oh it appears its just node.js 0.10 that is failing, does this need to be supported? Also if these changes failed 8.2.1 probably failed as well.

[rsimp]

Using nvm to switch over to node 0.10 and then running:
rm -rf node_modules/ && npm install && npm test

I've ascertained that the same test has failed on node 0.10 since v8.1.0 and v8.0.0 won't run entirely due to a forEach issue.

The test that's failing is issue #163 - Authorization header isn\'t mocked inside test/test_intercept.js. It's timing out when trying to issue a non mocked call to www.example.com.

[rsimp]

This was the only line added

[gr2m]

Oh it appears its just node.js 0.10 that is failing, does this need to be supported? Also if these changes failed 8.2.1 probably failed as well.

No they don’t, see the supported versions at https://github.com/node-nock/nock#node-version-support

Your PR is great as is though, I’ll make a follow up PR which removes testing the old Node versions and any references to them in the code.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!