Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker resets on reload #452

Closed
6 tasks done
oie669 opened this issue Dec 2, 2018 · 1 comment
Closed
6 tasks done

Color picker resets on reload #452

oie669 opened this issue Dec 2, 2018 · 1 comment
Labels

Comments

@oie669
Copy link

oie669 commented Dec 2, 2018

What are the steps to reproduce?

  1. Add a color picker widget with "Send" set to "multiple values during editing"
  2. Deploy
  3. View the dashboard
  4. Pick a color
  5. Refresh the page twice

What happens?

On the first refresh, the color picker state is cleared, but the dashboard UI does not display the update.
On the second refresh, the cleared color picker state is properly shown.

Here is a debug of the message payloads at each point:

Set color in dashboard

12/1/2018, 7:31:53 PMnode: 341cbb14.e8efd4
msg.payload : string[6]
"ff1818"
12/1/2018, 7:31:53 PMnode: 341cbb14.e8efd4
msg.payload : string[6]
"ff1818"

Reload first time

12/1/2018, 7:32:12 PMnode: 341cbb14.e8efd4
msg.payload : string[0]
""
12/1/2018, 7:32:12 PMnode: 341cbb14.e8efd4
msg.payload : string[0]
""

Reload second time

12/1/2018, 7:32:26 PMnode: 341cbb14.e8efd4
msg.payload : string[0]
""

What do you expect to happen?

The color picker state should persist between reloads. Note: setting "Send" to "one value when released/closed" behaves as expected.

Please tell us about your environment:

  • Node-RED-Dashboard version: 2.11.0
  • Node-RED version: 0.17.5
  • node.js version: 6.11.0
  • npm version: 3.10.10
  • Platform/OS: armv7l/Linux
  • Browser: Chrome
@dceejay dceejay added the bug label Dec 2, 2018
@dceejay
Copy link
Member

dceejay commented Dec 2, 2018

Actually I think the bug is slightly different... it should not be cleared at all - it should retain the set value no matter how many times it's reloaded - as it does when in "one value" mode.

@dceejay dceejay added this to Work in Progress in Dashboard - Things to do Dec 2, 2018
@dceejay dceejay closed this as completed in 087fff8 Dec 7, 2018
@dceejay dceejay moved this from Work in Progress to Released to npm 2.12.2 in Dashboard - Things to do Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants