Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer 11 doesn't load ui_base and ui_switch component #515

Closed
tt92 opened this issue Jul 10, 2019 · 2 comments
Closed

Internet Explorer 11 doesn't load ui_base and ui_switch component #515

tt92 opened this issue Jul 10, 2019 · 2 comments

Comments

@tt92
Copy link

tt92 commented Jul 10, 2019

What happens?

When I open the Node-RED editor in IE11 I get two error messages saying that ui_base and ui_switch failed to load.

The Dashboard itself is accessible and the switches (designed in Chrome) are working as expected.
But they are not displayed correctly in the editor.

How can we fix this?

The issue seems to be caused by empty jQuery event handlers:

$(...).on("xy", )

Currently, there are 7 of these in the source code (6 in ui_base.html (lines 2198, 2200,...), 1 in ui_switch.html).

If you change it to

$(...).on("xy", function() {})

the issue seems to be solved.
Maybe they can even be removed completely? I'm not sure what they are actually good for...

Please tell us about your environment:

  • Node-RED-Dashboard version: 2.15.5
  • Node-RED version: 0.20.5
  • node.js version: 10.16.0
  • npm version: 6.9.0
  • Platform/OS: Win 10
  • Browser: IE 11 (11.0.130)

Cheers, Tobias

@dceejay
Copy link
Member

dceejay commented Jul 10, 2019

hmm - they should have just been .change(); - but got swept up in a global edit.
Will revert them.

@dceejay
Copy link
Member

dceejay commented Aug 11, 2019

Closed by bb3d87a

@dceejay dceejay closed this as completed Aug 11, 2019
@dceejay dceejay added this to Work in Progress in Dashboard - Things to do Aug 11, 2019
@dceejay dceejay moved this from Work in Progress to Release - 2.16.0 in Dashboard - Things to do Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants