Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group loses custom theme style if you open its edit panel two times in a row #2651

Closed
5 tasks
bonanitech opened this issue Jul 12, 2020 · 2 comments
Closed
5 tasks

Comments

@bonanitech
Copy link
Contributor

What are the steps to reproduce?

Using the Midnight theme (or any custom theme that changes .red-ui-flow-group-body), create a group, double-click to edit it, don't change anything, simply click Done, and double-click on the same group again.

What happens?

The group loses the style defined in the custom theme.

What do you expect to happen?

Please tell us about your environment:

  • Node-RED version: 1.1.2 (official Docker image)
  • Node.js version:
  • npm version:
  • Platform/OS: MacOS 10.15.5
  • Browser: Any browser
@knolleary
Copy link
Member

Can you export the group before and after each edit to see how the style property changes?

@bonanitech
Copy link
Contributor Author

Before:

[{"id":"277b5751.777658","type":"group","z":"d0505e55.8a4b8","style":{"stroke":"#2e333a","stroke-opacity":"0.5","fill":"#383c45","fill-opacity":"0.5","label":true,"label-position":"nw","color":"#a4a4a4"},"nodes":["e84d4816.5d9448"],"x":554,"y":549,"w":192,"h":82},{"id":"e84d4816.5d9448","type":"inject","z":"d0505e55.8a4b8","g":"277b5751.777658","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":660,"y":590,"wires":[[]]}]

First edit:

[{"id":"277b5751.777658","type":"group","z":"d0505e55.8a4b8","name":"","style":{"label":true},"nodes":["e84d4816.5d9448"],"x":554,"y":549,"w":192,"h":82},{"id":"e84d4816.5d9448","type":"inject","z":"d0505e55.8a4b8","g":"277b5751.777658","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":660,"y":590,"wires":[[]]}]

Second edit:

[{"id":"277b5751.777658","type":"group","z":"d0505e55.8a4b8","name":"","style":{"label":true,"fill":"none"},"nodes":["e84d4816.5d9448"],"x":554,"y":549,"w":192,"h":82},{"id":"e84d4816.5d9448","type":"inject","z":"d0505e55.8a4b8","g":"277b5751.777658","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":660,"y":590,"wires":[[]]}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants