Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nodes mqtt dependency from 2.18.8 - Current version is 4.2.1 - Getting deprecated warning #2694

Closed
5 tasks done
scottpageindysoft opened this issue Sep 4, 2020 · 3 comments
Labels
Milestone

Comments

@scottpageindysoft
Copy link

scottpageindysoft commented Sep 4, 2020

What are the steps to reproduce?

  • Start node-red
  • Observe log while node-red is starting

What happens?

Warning logged (node:7223) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

What do you expect to happen?

No warning

Please tell us about your environment:

  • Node-RED version: 1.1.3-git (embedded)
  • Node.js version: 14.4.0
  • npm version: 6.14.5
  • Platform/OS: Any
  • Browser: Chrome

Resolution

Update mqtt dependency in nodes/package.json. node-red uses 2.18.8 and the current version of mqtt.js is 4.2.1

@hardillb
Copy link
Member

hardillb commented Sep 4, 2020

Does MQTT.JS version 4.2.1 still support NodeJS version v8? (https://nodered.org/docs/faq/node-versions)

@knolleary
Copy link
Member

Updating the MQTT dependency had been on the to-do list for ages. Just need to figure out what two major version bumps means in terms of any breaking changes.

@knolleary
Copy link
Member

I've updated this dependency in the dev branch for the 1.2 release.

@knolleary knolleary added this to the 1.2 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants