HTTP Request with Got throws error and loose the response body when status code is not successful

[smiziara]

Current Behavior

When consuming Rest APIs using the HTTP Request connection, the current implementation with GOT is Throwing errors on non success status codes, that are "normal" with Rest APIs.

So instead of being able to handle the response, GOT throws an error and NodeRed 2 is replacing the payload with a concatenated message, loosing the response. This behavior is different from the previous version.

The current implementation uses a Catch after the GOT call, overriding the response body and the status code, leaving it impossible for the flow to provide a proper treatment.

msg.payload = err.toString() + " : " + url;
msg.statusCode = err.code || (err.response?err.response.statusCode:undefined);
nodeSend(msg);

Expected Behavior

We should be able to handle the output, with the response status code and body, like the previous version.

This behaviour can be changed in GOT but the Option (throwHttpErrors) is not exposed by NodeRed.

Steps To Reproduce

Using the HTTP Request connection, consume any Http endpoint that returns a non success status code, like 400.

Example flow

paste your flow here

Environment

• Node-RED version: 2.0.2
• Node.js version: 16.1
• npm version: 7.16
• Platform/OS: Windows
• Browser: Google Chrome