Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari doesn't show every setting in property Editor #4136

Closed
FlorianRueb opened this issue Apr 11, 2023 · 26 comments
Closed

Safari doesn't show every setting in property Editor #4136

FlorianRueb opened this issue Apr 11, 2023 · 26 comments

Comments

@FlorianRueb
Copy link

Current Behavior

Opening the property dialog of a random node doesn't show every settings field.

Expected Behavior

Open a property dialog, edit the settings fields, reopen the dialog > see what you've done.

Steps To Reproduce

Take a new flow, take a HTTP request node, open the property dialog, set up "GET" and "a UTF-string" as return, confirm the dialog.
Then open up the dialog again and see: no method and no return to see!

Example flow

paste your flow here

Environment

  • Node-RED version: 3.0.2
  • Node.js version: 19.9.0
  • npm version: 9.6.3
  • Platform/OS: DietPi v8.16.2 (Node-RED Host) / macOS 13.3.1 (Client)
  • Browser: Safari Version 16.4 (18615.1.26.11.23)
@marcus-j-davies
Copy link

marcus-j-davies commented Apr 11, 2023

I can confirm I have the same behaviour (have tested File Write, and the HTTP Request Node)

I should note: The console is not producing anything of concern

Forum Post:
https://discourse.nodered.org/t/safari-doesnt-show-every-setting-in-property-editor

Node RED: 3.0.0
Safari 16.4 (18615.1.26.11.23)

File Write Demo
dc417d47e37f40c60e3f696703af4838488f574a

@Steve-Mcl
Copy link
Contributor

@marcus-j-davies are you also running node v19?
Also, I note you are on safari 16.4. Isn't that in beta? (I'm not an apple user but I have a recollection that 16.3 is current version?)

@FlorianRueb can I ask why you are running a non LTS version of NODE please? Typically we recommend the LTS version of node (we do not test against odd numbered versions of node)

@marcus-j-davies
Copy link

Sorry, should have put Node version.

Node V - v16.15.1

Safari 16.4 is stable/current (comes with OSX)
16.5 is the BETA at this stage.

@FlorianRueb
Copy link
Author

Hi Steve,

yes, that's because it is the installation via the standard routine in DietPi.
Installed via "dietpi-software install 122". It's the easiest way to install Node-RED and all dependencies and get it working in DietPi...

@marcus-j-davies
Copy link

marcus-j-davies commented Apr 11, 2023

@Steve-Mcl

I think I have found where the problem may lie
Any select option where it's label is managed by i18n becomes blank when opening up the dialog again.

This of course is happening both with, the file write node and the HTTP request node - maybe other nodes also 🤷‍♂️

Return type

<select type="text" id="node-input-ret" style="width:70%;">
        <option value="txt" data-i18n="node-red:httpin.utf8">a UTF-8 string</option>
        <option value="bin" data-i18n="node-red:httpin.binary">a binary buffer</option>
        <option value="obj" data-i18n="node-red:httpin.json">a parsed JSON object</option>
</select>

Method

<select type="text" id="node-input-method" style="width:70%;">
        <option value="GET">GET</option>
        <option value="POST">POST</option>
        <option value="PUT">PUT</option>
        <option value="DELETE">DELETE</option>
        <option value="HEAD">HEAD</option>
        <option value="use" data-i18n="node-red:httpin.setby">- set by msg.method -</option>
</select>

This shows my findings
I tested setting the Method to - set by msg.method - - and boom! it become blank when opening it up again.

Apr-11-2023 21-19-25

Screenshot 2023-04-11 at 21 48 46

@FlorianRueb
Copy link
Author

But it must be more nodes.
I can find the problem also in the file read node and the edit json node for example... and the delay node.

@ralphwetzel
Copy link
Contributor

Lots of speculation here; I'll add another one - which is as well visible in the example Marcus posted: The focus is jumping around wildly.

When double clicking on the node, initially 'Nodes filtern' at the top of the left hand palette is focused, then the focus jumps on the incoming property window ... and thus eliminates - sometimes !! - the selection: The third time (in the example below) the value is displayed in the select element.

FocusIssue4

@marcus-j-davies

boom! it become blank when opening it up again.

No really. With a sharp eye on your screen cast, you can see that the values are present, when the window is incoming ... but then changed!

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Apr 11, 2023

Weird weirdness. Thanks for the info guys. Plenty of clues.

@marcus-j-davies if you know how to put break points on a dom element sub tree modification, perhaps you could see what call is clearing the list?

Also, do you happen to have the 3.1.0 beta running somewhere? (To see if this is present in Safari on the latest beta too)

@ralphwetzel
Copy link
Contributor

I see the exactly same behavior with the beta.1 & beta.2.
Safari @ 16.4

@marcus-j-davies
Copy link

marcus-j-davies commented Apr 11, 2023

I'm off the computer thingy for the night, but the only constant I'm seeing, is the difference between a select option using i18n and one that is not.

If you select an option that is not using i18n, then it's fine.

Example in the HTTP Request method. PUT, POST, GET etc etc do not use i18n - and they remain, but - use msg.method - does, and is not restored - or you have to click it to refresh the value.

It seems (from my limited testing) that any select element value using i18n will be affected.

Has this been an issue since Safari 16.4 🤷‍♂️.

Have only just noticed it - since its orginal report

@Steve-Mcl
Copy link
Contributor

Has this been an issue since Safari 16.4 🤷‍♂️.

Have only just noticed it - since its orginal report

My thoughts entirely. Would be good if someone still on 16.3 could check.

@FlorianRueb
Copy link
Author

FlorianRueb commented Apr 11, 2023

Lots of speculation here; I'll add another one - which is as well visible in the example Marcus posted: The focus is jumping around wildly.

When double clicking on the node, initially 'Nodes filtern' at the top of the left hand palette is focused, then the focus jumps on the incoming property window ... and thus eliminates - sometimes !! - the selection: The third time (in the example below) the value is displayed in the select element.

FocusIssue4 (https://user-images.githubusercontent.com/16342003/231284534-acaeaef9-f252-4d9c-bb02-a0800a62ed1e.gif)

@marcus-j-davies

boom! it become blank when opening it up again.

No really. With a sharp eye on your screen cast, you can see that the values are present, when the window is incoming ... but then changed!

Oh, maybe it has something to do with that thing, where you open a function node, click inside the code and get many lines selected. I'll try to make a screen capture...

marking.mov

@marcus-j-davies
Copy link

marcus-j-davies commented Apr 12, 2023

Has this been an issue since Safari 16.4 🤷‍♂️.
Have only just noticed it - since its orginal report

My thoughts entirely. Would be good if someone still on 16.3 could check.

Safari 15.6.1 : The problem does not appear to be apparent.

It maybe note worthy, my 15.6.1 safari is on an x86 processor (its a dated Mac), and my 16.4 safari is using Apple Silicon.

Unless there are some wasm modules in use with all this? - I can't imagine that will make any difference, but thought I'd mention it

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Apr 12, 2023

Thank you very much to all for the feedback and clues.

It is certainly looking like it is a safari 16.4 thing - or somewhere to start digging :)

@crxporter
Copy link

@Steve-Mcl - Marcus requested that I test this.

I have a Mac with Safari 16.3 and the issue is not happening on Safari 16.3.

On the same NR system using my Safari 16.4 updated MacBook - the issue is there.

Hope that maybe helps narrow things down. I'll hold off updating the 16.3 Mac in case you have more questions.

@marcus-j-davies
Copy link

And with that.

Here are the change logs for Safari 16.4
https://developer.apple.com/documentation/safari-release-notes/safari-16_4-release-notes <- Needle in here somewhere

@deqw
Copy link

deqw commented Apr 16, 2023

When I have the node properties open and then change MacOS to Dark Mode (or to Light from Dark) the captions reappear, but not the properties itself. After closing and opening the properties again the captions are gone again.
Screenshot 2023-04-16 at 12 00 41
Screenshot 2023-04-16 at 12 00 53

@kremik
Copy link

kremik commented Apr 23, 2023

Having the same problem with Node-red 3.0.2 and Safari 16.4. If I open Node Red in Brave/chrome Browser then it works fine

@Steve-Mcl
Copy link
Contributor

It seems this issue may be resolved with safari 16.5. Can one other person please confirm?

@marcus-j-davies
Copy link

I cant test right now, as haven't updated to latest OS

But!
https://developer.apple.com/documentation/safari-release-notes/safari-16_5-release-notes

Screenshot 2023-05-22 at 21 48 28

Could be related 🤷‍♂️

@dceejay
Copy link
Member

dceejay commented May 22, 2023

Yes - 16.5 fixes it for me.

@Steve-Mcl
Copy link
Contributor

Thank for confirming. Closing this issue.

@deqw
Copy link

deqw commented May 25, 2023

But not for me. Still empty properties in the forms. Running maxOS Ventura 13.4 (22F66) on Apple M2 Pro.

Screenshot 2023-05-25 at 15 22 42
Screenshot 2023-05-25 at 15 23 51

@dceejay
Copy link
Member

dceejay commented May 25, 2023

which node is that ?
(I'm also running 13.4 on an M2 but no longer have a problem)

@deqw
Copy link

deqw commented May 25, 2023

This is a state node. I see similar with a poll state node.

Screenshot 2023-05-25 at 15 49 52

@deqw
Copy link

deqw commented May 25, 2023

No I think I'm wrong now. It was the property caption not showing before. I was staring at empty properties that are not properties... This looks OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants