Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatable with TypeScript 4.9 #218

Closed
cjbarth opened this issue Nov 15, 2022 · 3 comments
Closed

Incompatable with TypeScript 4.9 #218

cjbarth opened this issue Nov 15, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@cjbarth
Copy link
Collaborator

cjbarth commented Nov 15, 2022

When using typescript@4.9, the following error appears, which doesn't exist on typescript@4.8:

TSError: ⨯ Unable to compile TypeScript:
src/inmemory-cache-provider.ts:25:50 - error TS2304: Cannot find name 'this'.

25 private removeKeyIfExpired: (key: keyof typeof this.cacheKeys, nowMs: number) => Promise;
@cjbarth cjbarth added the bug Something isn't working label Nov 15, 2022
@cjbarth cjbarth mentioned this issue Nov 15, 2022
Closed
@markstos markstos mentioned this issue Nov 16, 2022
Merged
@cjbarth cjbarth mentioned this issue Nov 16, 2022
Merged
@markstos
Copy link
Contributor

markstos commented Jun 9, 2023

@cjbarth Would this issue be resolved with TypeScript 5?

@cjbarth
Copy link
Collaborator Author

cjbarth commented Jun 9, 2023

I intend to do testing to figure that out. If it isn't resolved, we may need to adjust our code to work here.

@cjbarth
Copy link
Collaborator Author

cjbarth commented Apr 11, 2024

After moving to TypeScript 5.x, this problem went away.

@cjbarth cjbarth closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markstos @cjbarth