Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to fail hard if there should be valid top level signature and validation of top level signature failed #58

Closed
cjbarth opened this issue Apr 4, 2022 · 0 comments · Fixed by #83
Labels
enhancement New feature or request

Comments

@cjbarth
Copy link
Collaborator

cjbarth commented Apr 4, 2022

Currently, if the validation of the top-level signature fails, we continue after setting a variable. We should have an option, or perhaps just fail, if we find a top-level signature that isn't valid. Right now, node-saml will allow an invalid top-level signature. This allowance allows for a whole class of crafty attacks that cause a top-level signature to be invalid, but which preserve the signature of an assertion. See node-saml/passport-saml#671 for a more thorough discussion of this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant