Cannot call MultiSamlStrategy logout synchronously

[ricardosaracino]

logout was working when i wasnt using the multi strategy, but my await is not working using the MultiSamlStrategy.prototype.logout

import {MultiSamlStrategy as SamlStrategy} from '../strategies';

@Injectable()
export class SamlPassportLogoutInterceptor implements NestInterceptor {

    private logger = new GlobalLoggerService();

    constructor(@Inject(SamlStrategy) private readonly samlStrategy: SamlStrategy) {
    }

    async intercept(context: ExecutionContext, next: CallHandler): Promise<Observable<any>> {

        const req = context.switchToHttp().getRequest();
        const res = context.switchToHttp().getResponse();

        await (this.samlStrategy as any).logout(req, (error, redirectUrl) => {

            this.logger.debugReq(req, `Saml Redirect ${redirectUrl}`);

            if (error) {
                this.logger.errorReq(req, error);
            } else {
// redirect happens after next.handle
                res.redirect(redirectUrl);
            }
        });

// I hit this first 
        return next.handle();
    }
}

MultiSamlStrategy.prototype.logout = function (req, callback) {
  var self = this;

  this._options.getSamlOptions(req, function (err, samlOptions) {
    if (err) {
      return callback(err);
    }

    self._saml = new saml.SAML(Object.assign({}, self._options, samlOptions));
    self.constructor.super_.prototype.logout.call(self, req, callback);
  });
};

[stavros-wb]

MultiSamlStrategy needs to call getSamlOptions dynamically, so it will call the callback asynchronously

[ricardosaracino]

Ok... this is weird and i was a complete fluke that i stumbled on it .. but ...

changing this ...

@Get('logout')
@UseInterceptors(PassportLogoutInterceptor)
@ApiOperation({title: 'Handles the logout'})
public logout() {
}

to this fixed the problem

@Get('logout')
@UseInterceptors(PassportLogoutInterceptor)
@ApiOperation({title: 'Handles the logout'})
public logout(@Req() req, @Res() res) {
}

I wonder if @kamilmysliwiec can chime in on it

[ricardosaracino]

All in all i dont think this is passport-saml problem