Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/node-schedule not update for tz #507

Open
Ben07 opened this issue Sep 3, 2019 · 6 comments · May be fixed by #585
Open

@types/node-schedule not update for tz #507

Ben07 opened this issue Sep 3, 2019 · 6 comments · May be fixed by #585

Comments

@Ben07
Copy link

Ben07 commented Sep 3, 2019

I use typescript to write code and found that tz is not found in RecurrenceRule in @types/node-schedule.
please update it.
Thanks.

@wi-ski
Copy link

wi-ski commented Jul 23, 2020

I am from the future. This is still an issue <3

@wi-ski
Copy link

wi-ski commented Jul 23, 2020

Huh - I believe its there?

See: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node-schedule/index.d.ts#L114

☝️ Isn't that the would-be-desired state?

@kibertoad
Copy link
Contributor

I would prefer to have types embedded in this repo. If someone would make a PR for that, it would be gladly accepted.

@BehindTheMath
Copy link
Contributor

@kibertoad Do you want the code to be rewritten in TS, or keep it in JS and just add the type definitions?

@kibertoad
Copy link
Contributor

@BehindTheMath I'm open to both, actually. If you would volunteer to convert the project to TS, I would gladly accept such a PR. But having the type definitions I would consider a bare minimum for any JS project in 2021.

@BehindTheMath BehindTheMath linked a pull request Mar 1, 2021 that will close this issue
@lucas-labs
Copy link

Hi! I see converting to typescript is still in progress. But, in the meantime, can't we just grab the definitions already made by DefinitelyTyped and embed them in this repo? I think it's more convenient to have types embedded here rather than having to install a --save-dev package just for types. Is there any license issues I'm not aware of, or would this be possible to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants