-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types/node-schedule not update for tz #507
Comments
I am from the future. This is still an issue <3 |
Huh - I believe its there? See: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node-schedule/index.d.ts#L114 ☝️ Isn't that the would-be-desired state? |
I would prefer to have types embedded in this repo. If someone would make a PR for that, it would be gladly accepted. |
@kibertoad Do you want the code to be rewritten in TS, or keep it in JS and just add the type definitions? |
@BehindTheMath I'm open to both, actually. If you would volunteer to convert the project to TS, I would gladly accept such a PR. But having the type definitions I would consider a bare minimum for any JS project in 2021. |
Hi! I see converting to typescript is still in progress. But, in the meantime, can't we just grab the definitions already made by DefinitelyTyped and embed them in this repo? I think it's more convenient to have types embedded here rather than having to install a |
I use
typescript
to write code and found thattz
is not found inRecurrenceRule
in@types/node-schedule
.please update it.
Thanks.
The text was updated successfully, but these errors were encountered: