Skip to content

Commit

Permalink
chore: build on node 14 and drop node 8 and 32bit linux builds (#2079)
Browse files Browse the repository at this point in the history
- Build binaries on node 14 and test on node 14
- Node 14 is no longer being built for 32bit linux, not much I can do.
- Node 8 is out of LTS so it’s gone https://github.com/nodejs/Release#release-schedule

BREAKING CHANGE: Dropping node 8 and 32bit linux builds
  • Loading branch information
reconbot committed May 10, 2020
1 parent 485b615 commit e0c232c
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Expand Up @@ -10,10 +10,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Use Node.js 12
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 14
- name: upgrade npm
run: npm install -g npm
- name: npm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-merge.yml
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
# chances are that we'll never break on a merge to master on just one version of node
node-version: [12.x]
node-version: [14.x]
os: [ubuntu-latest, windows-latest, macos-latest]
steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [8.x, 10.x, 12.x]
node-version: [10.x, 12.x, 14.x]
os: [ubuntu-latest, windows-latest, macos-latest]
steps:
- uses: actions/checkout@v1
Expand Down
7 changes: 1 addition & 6 deletions .travis.yml
Expand Up @@ -19,12 +19,7 @@ env:
global:
- secure: "L+AGMJc5NAsuym+xzB4FWj0c2rCobosixkoxLBhDBVkLiYsMtfS9y1w8Xz0pbWKJnJAH9tfwHluu5aX2qYk2HbreSyNzy8hbPW+9RbSyAQexeiZG4mLuDEz0xvlpCCQBsS1OfMypQk0/JvL4oA9B/xasrpkeVuPI7dwAz2WcFms="
matrix:
- BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8"
- BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8" ARCH="x86"
matrix:
exclude:
- os: osx
env: BINARY_BUILDER="true" TRAVIS_NODE_VERSION="8" ARCH="x86"
- BINARY_BUILDER="true" TRAVIS_NODE_VERSION="14"

before_install:

Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Expand Up @@ -6,7 +6,7 @@ environment:
secure: iDcAJCYgJK4tffyzEHbMVR8DatJcIN8eY0h29p9JQkl43TcEcm6Z6JLOBpGDk1MJ

matrix:
- nodejs_version: "8"
- nodejs_version: "14"
binary_builder: "true"

platform:
Expand Down
2 changes: 1 addition & 1 deletion packages/bindings/lib/mocks/linux-list.js
Expand Up @@ -30,7 +30,7 @@ listLinux.emit = () => {
}

listLinux.reset = () => {
mockPorts = {}
mockPorts = undefined
}

module.exports = listLinux

0 comments on commit e0c232c

Please sign in to comment.