Stop removing all event listeners on close and disconnect #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
force-pushed
the
stop-removing-listeners
branch
from
fa8c13e
to
f4ba90c
Compare
| @@ -410,9 +410,6 @@ SerialPort.prototype.disconnected = function (err) { | |||
| debug('Disconnect completed with an exception: ' + JSON.stringify(e)); | |||
| } | |||
|
|
|||
| // TODO THIS IS CRAZY TOWN | |||
reconbot
added a commit
that referenced
this pull request
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address some of #702 and closes #638 and helps rwaldron/johnny-five#1037