Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS API should generate standards-compliant event objects #8

Closed
modeswitch opened this issue Oct 15, 2013 · 3 comments
Closed

JS API should generate standards-compliant event objects #8

modeswitch opened this issue Oct 15, 2013 · 3 comments
Labels
bug critical interop
Milestone
0.1

Comments

@modeswitch
Copy link

Right now the JS API passes webrtc objects (data channels, status codes) without wrapping them in an event object. This is not strictly comliant with the standard and will prevent webrtc libraries written for the browser from running on node-webrtc.
@fuson fuson mentioned this issue Oct 18, 2013
Closed
@kofd
Copy link
Contributor

kofd commented Dec 22, 2013

ah, should I address that in the implementation of the streams as well, or let this be fixed when it is addressed?

@modeswitch
Copy link
Author

make the errors like the ones currently being returned and we'll fix them all later

@piranna piranna mentioned this issue Feb 17, 2014
Merged
@piranna piranna mentioned this issue Feb 27, 2014
Merged
@modeswitch
Copy link
Author

Fixed.

@devnullmail devnullmail mentioned this issue Feb 19, 2015
Closed
@bioid bioid mentioned this issue Apr 24, 2015
Closed
@zedshaw zedshaw mentioned this issue Jun 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug critical interop
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@modeswitch @kofd