Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install not working on Heroku #45

Closed
lloydwatkin opened this issue Jan 9, 2014 · 9 comments · Fixed by #46
Closed

Install not working on Heroku #45

lloydwatkin opened this issue Jan 9, 2014 · 9 comments · Fixed by #46

Comments

@lloydwatkin
Copy link
Contributor

See xmppjs/xmpp.js#212 (comment)

@lloydwatkin
Copy link
Contributor Author

@lloydwatkin
Copy link
Contributor Author

@mrquincle @chris-rock

@chris-rock
Copy link
Contributor

@lloydwatkin
Copy link
Contributor Author

I'm not familiar with heroku, what's the best way to test this?

@mrquincle
Copy link

Heroku is really simple to set and free to try out. Just a basic node-xmpp example will do. You will need to add a Procfile with the line

web: node app.js

Following the quick start on https://devcenter.heroku.com/articles/getting-started-with-nodejs sets you up, I estimate, in less than 10 minutes.

@chris-rock
Copy link
Contributor

I think the main problem is, that the compilation fails and npm aborts the installation. Since node-stringprep works without the compilation, we just need to catch the npm error. From my perspective we could try the approach from postgre because the have a nodejs and a native version within the same module.

@lloydwatkin
Copy link
Contributor Author

we could push the original node-stringprep part down into another optional module and then have this as a falling back wrapper.

Will try and look at this heroku stuff, but realistically we're looking at Sunday until I can.

@mrquincle
Copy link

Okay, if I add the line:

 "install": "node-gyp rebuild || (exit 0)"

then this is the result: https://gist.github.com/mrquincle/8335834

@mrquincle
Copy link

That's fine.

For now just

    , "node-xmpp-client": "0.1.4"

solves it for me. That one links to the 0.2.x versions of node-xmpp-core which have it still as an optional dependency:

npm view node-xmpp-client@0.1.4 dependencies
{ request: '~2.27.0',
  ltx: '~0.3.2',
  'faye-websocket': '~0.7.0',
  'node-xmpp-core': '~0.2.0' }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants