Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test to meet new sals separation between client and server #207

Merged
merged 4 commits into from Dec 5, 2013

Conversation

chris-rock
Copy link
Member

update sasl test to meet new seperation

@lloydwatkin
Copy link
Member

I think in order to pass these tests you'll need to bump the node-xmpp-server version in your PRs package.json.

I'd suggest we also copy or move these tests to node-xmpp-server directly.

@chris-rock
Copy link
Member Author

the sasl test is already within the server project. besides bumping the versions I could also delete the test here if you like

@lloydwatkin
Copy link
Member

Just testing a patch to get node-xmpp to run tests in the breakout modules too, so delete would be fine by me.

@lloydwatkin
Copy link
Member

PR for that patch in, tests should work there once this is in :)

@chris-rock
Copy link
Member Author

we should be clear to go now

lloydwatkin added a commit that referenced this pull request Dec 5, 2013
update test to meet new sals separation between client and server
@lloydwatkin lloydwatkin merged commit 4e3444a into xmppjs:master Dec 5, 2013
@chris-rock chris-rock deleted the sasl branch December 8, 2013 11:06
sonnyp added a commit that referenced this pull request Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants