re-enable client integration tests #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
force-pushed
the
integration-tests
branch
4 times, most recently
from
568e5b9
to
fa74362
Compare
| @@ -25,7 +25,7 @@ describe('TCP client/server', function () { | |||
| cl = new xmpp.Client({ | |||
| jid: 'test@localhost', | |||
| password: 'test', | |||
| host: '::1', | |||
There was a problem hiding this comment.
for some reason I'd get ENETUNREACH on travis
| @@ -21,7 +21,7 @@ server.on('connection', function (connection) { | |||
| }) | |||
| }) | |||
|
|
|||
| describe.skip('C2S WebSocket server client', function () { | |||
There was a problem hiding this comment.
this was temporary disabled during the move to WebSocket final RFC and we forgot to re-enable it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
/packages/*/test/integrationto/test/integrationBenefits:
requires in unit tests cleaner (nounitsub-directory)