Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v0.2.0 notification specification and websockets #1722

Open
bourgeoa opened this issue Mar 15, 2023 · 4 comments
Open

Implement v0.2.0 notification specification and websockets #1722

bourgeoa opened this issue Mar 15, 2023 · 4 comments

Comments

@bourgeoa
Copy link
Member

Help needed

@csarven
Copy link
Member

csarven commented Apr 4, 2023

If this issue is to show intent to implement some of notifications specifications, can you please update the table in solid/notifications#141 (comment) or let me know so I can.

re the issue title, want to doublecheck whether you intended to write Webhook (and/)or Websocket notification channel type? (Vaguely recall a past discussion on it being about Websocket).

@TallTed
Copy link
Member

TallTed commented Apr 4, 2023

Better not to reference "latest" anything, significantly but not only because that may change from opening to closing of issue and/or PR.

Better to instead refer to specific version and/or date of external specs, docs, etc. I strongly advise updating the title of this issue as described.

@csarven
Copy link
Member

csarven commented Apr 4, 2023

I agree. I shared latest for quick navigation (general purpose communication). Not intended to suggest that latest URL should be implemented.

What's recommended elsewhere (in discussions, QA document) is to refer to specific versions when need to be clear about conformance.

Implementers are also encouraged to use specific URIs in code comments or in other communication. For testing and reporting purposes, generally versioned is preferred, but it could be anything - I'd suggest either a published versioned URI or an editor's draft URI. It depends on how the reports are purposed. Versioned would be for wide communication whereas the ED would be more local/internal communication or experimental/WIP.

I've updated my earlier comment to include the versioned URI.

@bourgeoa bourgeoa changed the title Implement latest notification specification and webhooks Implement latest notification specification and websockets Apr 15, 2023
@bourgeoa bourgeoa changed the title Implement latest notification specification and websockets Implement v0.2.0 notification specification and websockets Apr 15, 2023
@bourgeoa
Copy link
Member Author

A few links to help anyone interested in this issue :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants