Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git dependency on global install causes install failures with sudo #796

Closed
justinwb opened this issue Sep 29, 2018 · 4 comments
Closed

Git dependency on global install causes install failures with sudo #796

justinwb opened this issue Sep 29, 2018 · 4 comments
Assignees
Labels

Comments

@justinwb
Copy link
Contributor

In the most recent path release 4.1.4, a user reported being unable to do a global install of solid-server when sudoed as root. Looks like a git dependency has creeped back in. Also we should ensure travis is catching cases like this as part of the resolution.

npm ERR! Command failed: /usr/bin/git clone --depth=1 -q -b gh-pages git://github.com/linkeddata/better-simple-slideshow.git /root/.npm/_cacache/tmp/git-clone-3bcf071d
npm ERR! fatal: could not create leading directories of '/root/.npm/_cacache/tmp/git-clone-3bcf071d': Permission denied

@timbl
Copy link
Contributor

timbl commented Sep 29, 2018

Original gitter char here: https://gitter.im/solid/node-solid-server?at=5baf952c271506518d904424 .. @RubenVerborgh poinst out probably mashlib.
We should then have a test at many levels or at least mashlib that git dependencies havent crept in n

@timbl
Copy link
Contributor

timbl commented Sep 29, 2018

$ cd mashlib/
$ grep git package-lock.json 
      "version": "github:linkeddata/better-simple-slideshow#gh-pages",
      "from": "better-simple-slideshow@github:linkeddata/better-simple-slideshow#gh-pages"
        "better-simple-slideshow": "github:linkeddata/better-simple-slideshow#gh-pages",
$ 

@RubenVerborgh
Copy link
Contributor

Working on this in #797.

In the meantime there is SolidOS/mashlib#18 on Mashlib. Can we use an npm version of better-simple-slideshow, @timbl?

@RubenVerborgh
Copy link
Contributor

RubenVerborgh commented Sep 29, 2018

Travis now complains if there are GitHub dependencies: https://travis-ci.org/solid/node-solid-server/jobs/435070122

Let's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants