Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a logger #920

Open
Ryuno-Ki opened this issue Nov 8, 2018 · 3 comments
Open

Use a logger #920

Ryuno-Ki opened this issue Nov 8, 2018 · 3 comments
Labels
revisit Not a current priority, reconsider later

Comments

@Ryuno-Ki
Copy link

Ryuno-Ki commented Nov 8, 2018

Think about using a logger library. My favourite is loglevel (because it's simple and supports plugins).

winston is popular also.

This way you can fine-tune the logging.

@megoth megoth added the triage Issues that need team review label Nov 8, 2018
@kjetilk kjetilk added revisit Not a current priority, reconsider later and removed triage Issues that need team review labels Nov 8, 2018
@kjetilk
Copy link
Member

kjetilk commented Nov 8, 2018

yeah, it is on my whiteboard for v.next (which is when we seriously introduce new things). I really miss multi-level logging, so it will definitely go in there. But it seems like way too much work to add different loglevels in the current code, so I hope you will excuse me for removing the triage label :-)

@Ryuno-Ki
Copy link
Author

Ryuno-Ki commented Nov 9, 2018

You could start small like I did in matrix-org/matrix-js-sdk#763 the other day.

@kjetilk
Copy link
Member

kjetilk commented Nov 14, 2018

So, it is not very likely we'd prioritize that highly in this code, but it is really needed in nodeSolidServer/acl-check#6 so I'll have a look at those hopefully. If there are any others I should be aware of, please let me know over in that bug :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revisit Not a current priority, reconsider later
Projects
None yet
Development

No branches or pull requests

3 participants