Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer window sizing doesn't work as expected #62

Closed
Pilvinen opened this issue Dec 19, 2016 · 16 comments
Closed

Composer window sizing doesn't work as expected #62

Pilvinen opened this issue Dec 19, 2016 · 16 comments

Comments

@Pilvinen
Copy link

It looks like this:

Which is not normal. When I start typing it stretches as I type. Scrolling doesn't work.

@frndxyz
Copy link

frndxyz commented Jan 2, 2017

you can fix it by replacing this line in : "nodebb-plugin-composer-default/static/lib/composer/resize.js"
$window.trigger('action:composer.resize',
{
containerHeight : postContainer.height() - 120
});

though its not a proper solution, but scrolling works and editor resize when you put content inside.

@julianlam
Copy link
Contributor

Can you reproduce @pitaj?

@pitaj
Copy link
Contributor

pitaj commented Jan 2, 2017

What browser?

Also, what version of this plugin and NodeBB?

@pitaj
Copy link
Contributor

pitaj commented Jan 2, 2017

Unable to repro in FF or Chrome

@frndxyz
Copy link

frndxyz commented Jan 3, 2017

@pitaj NodeBB V1.4.2, plugin version : 1.4.15

@pitaj
Copy link
Contributor

pitaj commented Jan 3, 2017

Try ./nodebb stop && ./nodebb build && ./nodebb start

@frndxyz
Copy link

frndxyz commented Jan 5, 2017

@pitaj it doesn't seems to fix the issue.

@julianlam
Copy link
Contributor

Actually, should be resolved with latest commit to this plugin.

@Pilvinen
Copy link
Author

Pilvinen commented Jan 5, 2017

You can test it at my forum here: https://foorumit.maailmanloppu.fi

@Pilvinen
Copy link
Author

I'm still having this issue with Nodebb v1.4.2, Redactor v2.0.1, Chrome 52.0.2743.82 (64-bit). But I highly doubt that it would be browser specific since all my forums users are having the same problem.

https://foorumit.maailmanloppu.fi

@julianlam
Copy link
Contributor

Plugin version?

@Pilvinen
Copy link
Author

Like I said above Redactor v2.0.1

@pitaj
Copy link
Contributor

pitaj commented Jan 10, 2017

This should be fixed in the latest version. Try updating to v2.0.3

@Pilvinen
Copy link
Author

Unfortunately this does not seem to be the case.

  1. Updated to v2.0.3.
  2. Shut down and restarted Nodebb just to be on the safe side.
  3. Still the same issues.
  • Does not scroll.
  • The editor window is smaller than it's supposed to be.

Screenshot:

@pitaj
Copy link
Contributor

pitaj commented Jan 11, 2017

Did you try the ./nodebb build thing I suggested before?

@Pilvinen
Copy link
Author

Yes. It didn't work. But I tried again and did git pull even though there should be no updates and after that ran ./nodebb build again and that did the trick.

It seems to work now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants