glur: there may be a mistake when backwards from right to left?

[tonykwok]

Hi, If my understanding is correct

for (j = width - 1; j >= 0; j--) {
    curr_out_r = curr_src_r * coeff_a0 + curr_src_r * coeff_a1 + prev_out_r * coeff_b1 + prev_prev_out_r * coeff_b2;
    curr_out_g = curr_src_g * coeff_a0 + curr_src_g * coeff_a1 + prev_out_g * coeff_b1 + prev_prev_out_g * coeff_b2;
    curr_out_b = curr_src_b * coeff_a0 + curr_src_b * coeff_a1 + prev_out_b * coeff_b1 + prev_prev_out_b * coeff_b2;
    curr_out_a = curr_src_a * coeff_a0 + curr_src_a * coeff_a1 + prev_out_a * coeff_b1 + prev_prev_out_a * coeff_b2;
}

should be:

for (j = width - 1; j >= 0; j--) {
    curr_out_r = curr_src_r * coeff_a0 + prev_src_r * coeff_a1 + prev_out_r * coeff_b1 + prev_prev_out_r * coeff_b2;
    curr_out_g = curr_src_g * coeff_a0 + prev_src_g * coeff_a1 + prev_out_g * coeff_b1 + prev_prev_out_g * coeff_b2;
    curr_out_b = curr_src_b * coeff_a0 + prev_src_b * coeff_a1 + prev_out_b * coeff_b1 + prev_prev_out_b * coeff_b2;
    curr_out_a = curr_src_a * coeff_a0 + prev_src_a * coeff_a1 + prev_out_a * coeff_b1 + prev_prev_out_a * coeff_b2;
}

'cause you use two curr_src_* in these formulas, is it right?

[puzrin]

Ups... seems you are right.

@a-rodin x & y passes become asymmetric after your commit 410b49b. Typo/bug?

[puzrin]

BTW we use mono16 blur only in pica and i don't see such problem there.

[ghost]

@puzrin yes, it seems to be a typo.

[puzrin]

Released fixed version. Thank you for report!