pica 6 breaking browserify build with browser-pack-flat plugin

[greghuc]

Hi there,

On upgrading to pica 6 (from 5.3) I am seeing "Uncaught ReferenceError: require is not defined" on my production browserify build. I have tracked the problem to browser-pack-flat, which is used by tinyify to minify the build.

browser-pack-flat says it "rewrites require() calls to simple variable assignments. If a module wraps require() somehow it probably will not work. In practice this is quite rare.".

Could you please explain what changed with the browserify build in pica 6, and whether it is rewriting require calls? Is this a hack? I am wondering whether there is an alternative approach to the recent changes that would fix this new ReferenceError.

I can actually avoid the ReferenceError by configuring tinyify not to use browser-pack-flat, but it does mean that the build files will be slightly larger.

And thanks again for pica :-)

Greg

[puzrin]

See d34e1db

It now uses "compiled" file as main entry, and derequire to allow browserify external packages. For eample, https://github.com/nodeca/image-blob-reduce build will fail without derequire.

[greghuc]

OK thanks - I've noted that pica is breaking with browser-pack-flat at: goto-bus-stop/browser-pack-flat#39

[puzrin]

I think, you need report to appropriate repos, this is not pica issue.

[greghuc]

Agreed, and thanks for the quick reply. Greg