Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG support #4

Closed
3 tasks done
puzrin opened this issue Apr 2, 2016 · 1 comment
Closed
3 tasks done

Add SVG support #4

puzrin opened this issue Apr 2, 2016 · 1 comment

Comments

@puzrin
Copy link
Member

puzrin commented Apr 2, 2016

  • Need streaming parser
    • need quick fail (if data does not starts with <)
    • avoid binary to text conversion before quick fail phase
    • may be sax could help (after quick fail passed)
  • Design API to be compatible - SVG can have floating & not numeric size
  • Should we allow to disable SVG mode?
@puzrin
Copy link
Member Author

puzrin commented May 28, 2016

Preliminary API suggestions:

  • Add result.wUnits & result.hUnits (px, em, ...). px everywhere except SVG.
  • Allow floats for result.width & result.height
  • Add options param (second) with allowed types list:
    • { types: [ 'svg', 'tiff', 'png', 'webp', ...] }
    • "jpg png webp"
  • ? Add .default() method: .default({ types: [ 'svg', 'tiff', 'png', 'webp', ...] })

@puzrin puzrin closed this as completed Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant