Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example / Greenlock broken #14

Closed
RevolvingDCON opened this issue Jun 1, 2020 · 4 comments
Closed

Example / Greenlock broken #14

RevolvingDCON opened this issue Jun 1, 2020 · 4 comments
Labels
documentation Documentation needs changing

Comments

@RevolvingDCON
Copy link

RevolvingDCON commented Jun 1, 2020

Using the Greenlock v4 example, it returns: UnhandledPromiseRejectionWarning: Error: missing 'packageAgent' and also failed to readname and/or 'version' from 'package.json'

There's also no documentation on Greenlock v4 so I'm not entirely sure how to debug this..

Edit: Formatting

@Rautherdir
Copy link
Contributor

This is caused by both not specifying a packageAgent when calling Greenlock.create, and not having a package.json file containing either a 'name' or a 'version' field, (which Greenlock uses to create a default packageAgent if it isn't specified)

I'll see if I can update that Greenlock v4 example to have packageAgent with it's default value though, which should help prevent this from being an issue in the future.

@RevolvingDCON
Copy link
Author

Awesome thanks! I understand this is not an issue thread for Greenlock, however I had since added the packageAgent as per their example yet it still failed. You don't happen to know if greenlock is still actively being developed do you?

@Rautherdir
Copy link
Contributor

I'm not sure if it's still being actively developed or not, a 4 month hiatus isn't unheard of. If you added packageAgent the way it's specified in their example, you'll need a package.json file in your project. (preferably with name and version, so it doesn't set the packageAgent to just '/')

@Cherry Cherry added the documentation Documentation needs changing label Jul 31, 2020
@Cherry
Copy link
Member

Cherry commented Jul 31, 2020

I'm going to close this as I believe it was resolved in #15. Feel free to open a new issue if you run into any other problems!

@Cherry Cherry closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation needs changing
Projects
None yet
Development

No branches or pull requests

3 participants