Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage from 97% to 100% #9

Open
Cherry opened this issue Oct 9, 2019 · 3 comments
Open

Increase code coverage from 97% to 100% #9

Cherry opened this issue Oct 9, 2019 · 3 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@Cherry
Copy link
Member

Cherry commented Oct 9, 2019

Code coverage for this library currently sits around 97%, with only a few uncovered lines.

See https://coveralls.io/github/nodecraft/ya-bbcode for details.

Adding tests to cover the few remaining lines would be great.

@Cherry Cherry added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 9, 2019
@EddyVinck
Copy link

Hi Cherry,

Maybe I can help with this. I'm having some trouble finding the uncovered lines with the link you posted.

Thanks.

@Cherry
Copy link
Member Author

Cherry commented Oct 9, 2019

Thanks @EddyVinck. If you click into the ya-bbcode.js file via that link, you'll see something like this: https://coveralls.io/builds/26213398/source?filename=ya-bbcode.js

The yellow/red lines are uncovered, such as 137.

You can also get a similar report locally if you run "npm test", which will produce something like this.

@EddyVinck
Copy link

Hi, thanks for explaining. I'll see what I can do. It's getting late here though, so maybe tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants