Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript #101

Open
Zizaco opened this issue Mar 12, 2019 · 4 comments
Open

TypeScript #101

Zizaco opened this issue Mar 12, 2019 · 4 comments
Assignees
Projects

Comments

@Zizaco
Copy link

Zizaco commented Mar 12, 2019

This seems to be the kind of project that would benefit very much from TypeScript.

I'm saying this based in the fact that this is already a kind of a port of java code, it's class and interface based, it's a library and that it should be well documented and easy to use.

What are your feelings about the subject?

@krystianity
Copy link
Member

Hi @Zizaco I totally agree, all of our new stuff is written (mostly) in TS anyways :)

@zmays
Copy link

zmays commented May 2, 2020

Hey, interested in helping. Not seeing any typescript besides the definition file. What is the new stuff you are referring to?

@wtrocki
Copy link
Member

wtrocki commented Aug 10, 2020

Big fan of typescript. I somehow missed that issue and created #155.
As guy who did not actually wrote the library this will be also great place to learn how it works under the hood.

Since there is no much feature development I think it is worth to create typescript branch and start porting some of the code.

@wtrocki wtrocki self-assigned this Aug 10, 2020
@rob3000
Copy link
Member

rob3000 commented Aug 10, 2020

+1 for this @wtrocki i've already start converting node-sinek in this pr: nodefluent/node-sinek#154

@rob3000 rob3000 added this to In progress in The 6th Day Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
The 6th Day
  
In progress
Development

No branches or pull requests

5 participants