Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game.settings variables can only be referenced by an active treatment in views #7

Closed
broliver opened this issue Mar 21, 2017 · 4 comments

Comments

@broliver
Copy link

Values and variables defined in game.settings.js can only be referenced by an active treatment (in the views):

var newVariable = settings.treatmentName.variable;

Since it is sometimes necessary to deactivate certain treatments, it would be preferable if it were possible to reference them directly without being tied to a specific treatment.

@shakty
Copy link
Member

shakty commented Apr 19, 2017

Fixed in branch viewsSettings. Will be merged into version 4.0.0.

@shakty shakty closed this as completed Apr 19, 2017
@shakty
Copy link
Member

shakty commented Apr 19, 2017

In case no authorization is on place, current implementation fails to detect the correct treatment. Need to assign a cookie even if no auth is used. Re-opening.

@shakty shakty reopened this Apr 19, 2017
@shakty
Copy link
Member

shakty commented Apr 19, 2017

Might be fixed now also when no auth is available (new option). Requires more testing, stays open for now

@shakty
Copy link
Member

shakty commented Sep 11, 2018

This is fixed now. Requires authorization or noAuthCookie to be enabled

@shakty shakty closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants