Cannot build when parent directory contains space(s) #123
Description
Duplicate, but not really solved: #80
I have a directory named Project Dev that I put all of the Git project clones into.
When I build nodegit with:
npm run-script gen && npm install && npm testI eventually receive the following error:
clang: error: no such file or directory: 'Dev/nodegit/vendor/libgit2/build'Notice the Dev instead of Project Dev.
I have a space in my path for the purpose of vetting out this error in dependencies. I can change it on my end, but I do not intend to have as a requirement to my project using nodegit: "your installation path must not contain any spaces".
Complete Log
npm run-script gen && npm install && npm test
> nodegit@0.1.0 gen /Users/glavin/Documents/Project Dev/nodegit
> node gen.js
> nodegit@0.1.0 install /Users/glavin/Documents/Project Dev/nodegit
> node install.js
[nodegit] Downloading libgit2 dependency.
[nodegit] Building libgit2 dependency.
-- The C compiler identification is Clang 5.0.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
zlib was not found; using bundled 3rd-party sources.
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/glavin/Documents/Project Dev/nodegit/vendor/libgit2/build
Linking C shared library libgit2.dylib
[100%] Built target git2
[nodegit] Building native module.
2014-01-05 05:39:41.358 xcodebuild[23063:1007] Could not fetch 'View' main menu item
CXX(target) Release/obj.target/nodegit/src/base.o
CXX(target) Release/obj.target/nodegit/src/blob.o
CXX(target) Release/obj.target/nodegit/src/commit.o
CXX(target) Release/obj.target/nodegit/src/oid.o
CXX(target) Release/obj.target/nodegit/src/reference.o
CXX(target) Release/obj.target/nodegit/src/object.o
CXX(target) Release/obj.target/nodegit/src/repo.o
CXX(target) Release/obj.target/nodegit/src/index.o
../src/index.cc:723:7: warning: unused variable 'result' [-Wunused-variable]
int result = git_index_find(
^
1 warning generated.
CXX(target) Release/obj.target/nodegit/src/index_entry.o
CXX(target) Release/obj.target/nodegit/src/index_time.o
CXX(target) Release/obj.target/nodegit/src/tag.o
CXX(target) Release/obj.target/nodegit/src/revwalk.o
CXX(target) Release/obj.target/nodegit/src/signature.o
CXX(target) Release/obj.target/nodegit/src/time.o
CXX(target) Release/obj.target/nodegit/src/tree.o
CXX(target) Release/obj.target/nodegit/src/tree_builder.o
CXX(target) Release/obj.target/nodegit/src/tree_entry.o
CXX(target) Release/obj.target/nodegit/src/diff_find_options.o
CXX(target) Release/obj.target/nodegit/src/diff_options.o
CXX(target) Release/obj.target/nodegit/src/diff_list.o
CXX(target) Release/obj.target/nodegit/src/patch.o
CXX(target) Release/obj.target/nodegit/src/delta.o
CXX(target) Release/obj.target/nodegit/src/diff_file.o
CXX(target) Release/obj.target/nodegit/src/diff_range.o
CXX(target) Release/obj.target/nodegit/src/threads.o
CXX(target) Release/obj.target/nodegit/src/refdb.o
CXX(target) Release/obj.target/nodegit/src/odb_object.o
CXX(target) Release/obj.target/nodegit/src/odb.o
CXX(target) Release/obj.target/nodegit/src/submodule.o
../src/submodule.cc:734:27: warning: cast to 'unsigned int *' from smaller integer type 'int32_t' (aka 'int') [-Wint-to-pointer-cast]
from_status = (unsigned int *) args[0]->ToInt32()->Value();
^
1 warning generated.
CXX(target) Release/obj.target/nodegit/src/remote.o
../src/remote.cc:287:11: warning: variable 'from_progress_cb' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (args[0]->IsFunction()) {
^~~~~~~~~~~~~~~~~~~~~
../src/remote.cc:292:28: note: uninitialized use occurs here
baton->progress_cb = from_progress_cb;
^~~~~~~~~~~~~~~~
../src/remote.cc:287:7: note: remove the 'if' if its condition is always false
if (args[0]->IsFunction()) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/remote.cc:286:52: note: initialize the variable 'from_progress_cb' to silence this warning
git_transfer_progress_callback from_progress_cb;
^
= NULL
1 warning generated.
CXX(target) Release/obj.target/nodegit/src/clone_options.o
SOLINK_MODULE(target) Release/nodegit.node
clang: error: no such file or directory: 'Dev/nodegit/vendor/libgit2/build'
make: *** [Release/nodegit.node] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/Cellar/node/0.10.24/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:789:12)
gyp ERR! System Darwin 13.0.0
gyp ERR! command "node" "/usr/local/Cellar/node/0.10.24/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build"
gyp ERR! cwd /Users/glavin/Documents/Project Dev/nodegit
gyp ERR! node -v v0.10.24
gyp ERR! node-gyp -v v0.12.1
gyp ERR! not ok
npm ERR! nodegit@0.1.0 install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the nodegit@0.1.0 install script.
npm ERR! This is most likely a problem with the nodegit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node install.js
npm ERR! You can get their info via:
npm ERR! npm owner ls nodegit
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 13.0.0
npm ERR! command "/usr/local/Cellar/node/0.10.24/bin/node" "/usr/local/bin/npm" "install"
npm ERR! cwd /Users/glavin/Documents/Project Dev/nodegit
npm ERR! node -v v0.10.24
npm ERR! npm -v 1.3.21
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /Users/glavin/Documents/Project Dev/nodegit/npm-debug.log
npm ERR! not ok code 0I hope this is a quick and easy fix. I cannot use this project until it is resolved. I am going to try and fix it myself tomorrow, but I am not entirely sure where to start. If someone could even point me in the right direction I'll try my best to fix it and provide a Pull Request.
Thank you.