Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable names in the Docs? #157

Closed
bcomnes opened this issue May 3, 2014 · 3 comments
Closed

Variable names in the Docs? #157

bcomnes opened this issue May 3, 2014 · 3 comments
Labels

Comments

@bcomnes
Copy link

bcomnes commented May 3, 2014

I was reading the API docs and, maybe I am totally off here, but it looks like there are variable names instead of the valid options in some of the docs.

IE: GIT_DIRECTION_FETCH and GIT_DIRECTION_PUSH are supposed to be numbers, but they are not noted anywhere.

@tbranyen
Copy link
Member

tbranyen commented May 3, 2014

They are constants. I went to the libgit2 GitHub and searched for them:

https://github.com/libgit2/libgit2/blob/e5bdf82976c631a5b4cc36d8bfad61de609d7802/include/git2/net.h#L30-L33

Looks like you can use 0 or 1 depending on the direction. Once I get the net file included those should be present in the code.

@tbranyen
Copy link
Member

This depends more on this issue being resolved: #171

@maxkorp
Copy link
Collaborator

maxkorp commented Dec 2, 2014

This is an issue with the website, gonna create an issue over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants