Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a production-ready demo app #189

Closed
cvl opened this issue Apr 9, 2020 · 5 comments
Closed

Create a production-ready demo app #189

cvl opened this issue Apr 9, 2020 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@cvl
Copy link

cvl commented Apr 9, 2020

Atm all demo apps are developer sandbox only (i.e. "works on my pc").

Suggestion to create a production level demo app (at least for MacOS): i.e. simple app, which can be signed, notarized (with complete how-to readme & necessary scripts), and accepted by gatekeeper.

@a7ul
Copy link
Collaborator

a7ul commented Apr 9, 2020

Yep, this is definetly a critical issue.
I can try and get this done possibly during these Easter vacation days. @cvl

@a7ul a7ul added bug Something isn't working help wanted Extra attention is needed labels Apr 9, 2020
@cvl
Copy link
Author

cvl commented Apr 9, 2020

That would be amazing :)

@cvl
Copy link
Author

cvl commented Apr 9, 2020

Also consider using a fork of https://github.com/mysteriumnetwork/mysterium-vpn-desktop as reference app for this.

@a7ul
Copy link
Collaborator

a7ul commented Apr 13, 2020

Hi @cvl
I managed to get a signed, notarized and gatekeeper passing build ready.
I built a small demo app here: https://github.com/master-atul/DadJokes
I pretty much tweaked your script to make it more maintainable.

There was a horrible typo in nodegui packer code that led me bang my head for 2 days.
The issue was that
Contents/MacOs ---> is incorrect
Contents/MacOS ----> is correct
This means any binary kept inside this (which is qode binary) will not be properly signed for some reason. But since Mac doesnt care about case sensitivity in folder names, the app package would run successfully anyway.

So in order to fix your setup. Just upgrade to packer v1.4.1 and run the init and pack again.
or maybe just rename MacOs --> MacOS
Then use the pack and notarize scripts inside https://github.com/master-atul/DadJokes

I will get a guide up soon. But for now this should work. Let me know if you face any issues.

@cvl
Copy link
Author

cvl commented Apr 14, 2020

Looks like it's working!

Thanks a lot for great work, Atul :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants