fix eventemitter madness, be careful around pausing here too #206
Conversation
|
@quartzjer This looks good. So good that I would ask that you update other places you see |
|
Ok, I honestly tried to fix this elsewhere, but I got in the weeds quickly on knowing what kind of larger impact it would have, I don't know the internals of http-proxy well enough to have any confidence in twiddling these bits. It seems that for all the instances of tracking flushed, paused, and attaching drain listeners, that there needs to be some way to check if the drain listener is attached for-the-specific-paired-socket, and using a paused variable could actually result in some edge cases of a full standstill. I'm not sure how to do this properly in all the other places with my relatively shallow understanding of http-proxy, and may not have the time to do a deep dive and learn it all any time soon :( cc @temas |
|
I decided to go the safest route possible, and just have a variable per instance. I tested this everywhere we were seeing the event emitter leak on the locker project and it runs clean now. Should be good to go I think? |
|
Does the current patch look good? |
|
Things have diverged so much from this that I can't merge it in. If you encounter this in |
Much happier :)