Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

protect release branches #129

Closed
MylesBorins opened this issue May 18, 2017 · 7 comments
Closed

protect release branches #129

MylesBorins opened this issue May 18, 2017 · 7 comments

Comments

@MylesBorins
Copy link

We should protect all vX.x release branches to only be pushable by @nodejs/release

there is no reason for anyone else to be pushing to those branches and they shouldn't be able to be force pushed without documentation.
@jasnell
Copy link
Member

jasnell commented May 18, 2017

SGTM

1 similar comment
@mcollina
Copy link
Member

SGTM

@evanlucas
Copy link

I think that's a good idea

@Fishrock123
Copy link
Member

/shrug

seems fine I suppose

@MylesBorins
Copy link
Author

/shrug

seems fine I suppose

@Fishrock123 is this a -1? Is there a reason you think this shouldn't happen? This comment isn't really helping to move the conversation forward and I don't see it as particularly productive

@refack
Copy link

refack commented Jun 5, 2017

@MylesBorins AFAIK this was done, or should this still be open?

@refack refack mentioned this issue Jun 5, 2017
Closed
@MylesBorins
Copy link
Author

Lol I duped

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mcollina @refack @jasnell @MylesBorins @evanlucas @Fishrock123