Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the license for examples to MIT #456

Closed
gabrielschulhof opened this issue Jul 16, 2023 · 2 comments
Closed

Consider changing the license for examples to MIT #456

gabrielschulhof opened this issue Jul 16, 2023 · 2 comments
Milestone

Comments

@gabrielschulhof
Copy link
Collaborator

We have several examples in the node-addon-examples repo that are licensed ISC. I suspect this is because npm init by default sets the license to ISC. Some do not mention a license, and a few licenses are MIT though:

$ git grep -nHE 'license.?:'
a-first-project/node-addon-api/package.json:15:  "license": "ISC"
napi-asyncworker-example/node-addon-api/package.json:22:  "license": "MIT"
object-wrap-demo/node-addon-api/package.json:15:  "license": "ISC"
promise-callback-demo/node-addon-api/package.json:17:  "license": "ISC"
website/docs/getting-started/first.md:55:license: (ISC)
website/docs/getting-started/helloworld.md:50:license: (ISC) 
website/docs/getting-started/objectwrap.md:57:license: (ISC)
website/package.json:14:  "license": "MIT",

Shall we consider harmonizing the licenses?

@gabrielschulhof gabrielschulhof added this to the Milestone 11 milestone Jul 16, 2023
@mhdawson
Copy link
Member

@gabrielschulhof we might need the ok from the contributors to each of the examples to change the licence. Can you take a look at who the people for have contributed to the examples are so that we can see how hard it might be to get the oks?

@gabrielschulhof gabrielschulhof changed the title Consider chaning the license for examples to MIT Consider changing the license for examples to MIT Jul 28, 2023
@gabrielschulhof
Copy link
Collaborator Author

All the relevant PRs have landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants