Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit need for napi_set_function_name #78

Closed
boingoing opened this issue Feb 1, 2017 · 2 comments
Closed

Revisit need for napi_set_function_name #78

boingoing opened this issue Feb 1, 2017 · 2 comments
Assignees
@boingoing
Milestone
Milestone 6 (PR S...

Comments

@boingoing
Copy link

ChakraCore (and possibly other engines) do not support changing the function name after creating a function. Let's add an optional name parameter to napi_create_function instead. If it's possible, can we also remove napi_set_function_name?
@boingoing boingoing mentioned this issue Feb 1, 2017
Closed
@aruneshchandra aruneshchandra added this to the Milestone 5 milestone Feb 2, 2017
@mhdawson
Copy link
Member

mhdawson commented Feb 2, 2017

@boingoing do we know if any of the existing ports or examples use napi_set_function_name ?
I agree that it should not be part of the API if it is not possible to support across engines.

@jasongin jasongin mentioned this issue Feb 6, 2017
Closed
@aruneshchandra aruneshchandra removed this from the Milestone 5 milestone Feb 23, 2017
@boingoing boingoing mentioned this issue Mar 15, 2017
Merged
@boingoing
Copy link
Author

Resolved by #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boingoing boingoing

Labels
None yet
Projects
None yet
Milestone
Milestone 6 (PR Submission)
Development

No branches or pull requests
3 participants
@boingoing @mhdawson @aruneshchandra