-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-test-commit-windows-coverage-daily looks broken #2645
Comments
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
ping @nodejs/coverage-admins again. |
One way to resolve this issue would be to retire our Jenkins-generated coverage and rely on https://app.codecov.io/gh/nodejs/node which is generated by GitHub Actions. |
Argh, although I guess that would mean no C++ coverage reports? |
Is the problem that an expectation of Node.js 14 is coded somewhere (maybe in an environment variable set by the job?) but running this on the master branch compiles Node.js 18 and the job errors because of that?:
|
Yeah, looks like |
You'll probably need to work out how node-test-commit-windows-fanned is setting and passing |
It looks like it's hardcoded in the configuration seen at https://ci.nodejs.org/view/All/job/node-test-commit-windows-coverage-daily/configure. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
@nodejs/coverage-admins https://ci.nodejs.org/job/node-test-commit-windows-coverage-daily/ looks broken.
e.g. https://ci.nodejs.org/job/node-test-commit-windows-coverage-daily/535/
➡️ https://ci.nodejs.org/job/node-compile-windows/40368/
All compile subjobs fail:
so I imagine this has been broken since Node.js 15. Looks like
NODEJS_MAJOR_VERSION
doesn't get set for the compile job so defaults to14
leading to the mismatch.The text was updated successfully, but these errors were encountered: