All windows/arm64 machines are offline

[MoLow]

https://ci.nodejs.org/label/win10-arm64-COMPILED_BY-vs2019-arm64/
https://ci.nodejs.org/label/win10-vs2019-arm64-COMPILED_BY-vs2019-arm64/

[MoLow]

cc @nodejs/build @nodejs/build-infra

[pbo-linaro]

I restarted nearform machines, and noticed the jenkins service is not launched automatically anymore (using nssm). @sxa @joaocgreis Did you change anything regarding this during the week?

Temporarily, I launched "C:/jenkins.bat" manually, so both nearform hosts are online again. But they won't restart automatically if machine restarts...

For the 2 other machines (msft), I don't have any connection information, so I'll leave someone with credentials solve this.

[sxa]

Nothing changed from my perspective - only thing I've done on this recently was make the CI tests on this platofrm run automatically and that was a change on the jenkins side. The restarting of the agents doesn't appear to have worked - they're still offline in the jenkins UI, therefore I'm going to disable ARM64 for now and delete the backlog of jobs that aren't running.

[pbo-linaro]

Ok. Seems like nearform machine have been rebooted during the night.

I just reconfigured the service, so that jenkins-agent starts automatically on boot. They are now both online 👍

For the two msft machines, I can help too, but I need the credentials to connect to them.

[sxa]

Happy for this to be closed now on the basis that the agents are now live and the agent should restart itself properly on subsequent reboots. Thanks @pbo-linaro !

[sxa]

@pbo-linaro Looks like we've still got problems: https://ci.nodejs.org/job/node-test-binary-windows-native-suites/nodes=win10-vs2019-arm64-COMPILED_BY-vs2019-arm64/15972/console

Error: Could not find any Visual Studio installation to use

I've disabled ARM64 again until this is resolved.

(Reported by @GeoffreyBooth in slack)

[pbo-linaro]

Root cause does not seem to be Visual Studio, as it's well installed (windows-arm-simple still compiles fine).

To investigate this, I'll need access to this job configuration. I send you an email for details.

[pbo-linaro]

After investigation, the errors comes from a step that build node C++ addons (when running tests).

On December 17th, something was changed, that made CI to use latest node/node-gyp module (20.0.0-pre/9.3.0). This can be viewed on this job history page. Job 15941 was working, while job 15943 started to fail.

Before:

> "Release\node.exe" "c:\workspace\node-test-binary-windows-native-suites\node\tools\build-addons.js" "c:\workspace\node-test-binary-windows-native-suites\node\deps\npm\node_modules\node-gyp\bin\node-gyp.js" "c:\workspace\node-test-binary-windows-native-suites\node\test\addons" 
...
gyp info using node-gyp@5.1.0
gyp info using node@14.21.3-pre | win32 | arm64
...
gyp info find VS using VS2019 (16.11.32106.194) found at:
gyp info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp info find VS run with --verbose for detailed information

After:

"Release\node.exe" "c:\workspace\node-test-binary-windows-native-suites\node\tools\build-addons.mjs" "c:\workspace\node-test-binary-windows-native-suites\node\deps\npm\node_modules\node-gyp\bin\node-gyp.js" "c:\workspace\node-test-binary-windows-native-suites\node\test\addons" 
...
gyp info using node-gyp@9.3.0
gyp info using node@20.0.0-pre | win32 | arm64
...
gyp ERR! find VS 
gyp ERR! find VS msvs_version not set from command line or npm config
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer, try re-running with '--loglevel silly' for more details
...
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
...

I could not find the origin of this change, as nothing in nodejs/node, or nodejs/build repositories changed. It does not seem to be related to any publication of new release on npm neither. If someone has a clue about this, you're welcome to solve the mystery!

I followed the given advice and installed VS2022, which solved the issue, as this install can be found. No problem, as only the addons are built with it, and not node itself.

@sxa You can restart arm64 CI, and tests will be launched like before (I checked that locally, it now works on both machines).

[sxa]

@pbo-linaro Is there anything else you need from me on this one? It sounds like the compiler upgrade has done everything we need!

[pbo-linaro]

@StefanStojanovic is taking ownership of this, and will enable new machines for Arm64 CI.