Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin or update GN version #3335

Closed
targos opened this issue May 3, 2023 · 2 comments · Fixed by #3659
Closed

Unpin or update GN version #3335

targos opened this issue May 3, 2023 · 2 comments · Fixed by #3659
Labels

Comments

@targos
Copy link
Member

targos commented May 3, 2023

Node.js 14 is EoL.

gn_select_compiler: "{{ compiler[os]|default(compiler[os|stripversion])|default('true') }}"
# Pin gn for now so we can still build older versions of V8 in Node.js 14.
# Refs: https://github.com/nodejs/node/pull/40689#issuecomment-956303875
gn_version: 69ec4fc

@targos targos added the ansible label May 3, 2023
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@richardlau
Copy link
Member

Rolling forward the gn version in #3659.
For now I've just rolled the version to a later commit (within the last few weeks). While we could unpin that might risk the machines having differing versions of gn on them which might make diagnosing any future issues tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants