Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow faking a tty for tests that need it #167

Open
bengl opened this issue Aug 17, 2016 · 3 comments · May be fixed by XirdigH/citgm#4
Open

Allow faking a tty for tests that need it #167

bengl opened this issue Aug 17, 2016 · 3 comments · May be fixed by XirdigH/citgm#4
Milestone

Comments

@bengl
Copy link
Member

bengl commented Aug 17, 2016

Either for all modules as a global option, or one a module-by-module basis as part of their config in lookup.json.

Using something like https://github.com/chjj/pty.js

This is to help stop issues like nodejs/node#8138 before they're released.

@MylesBorins
Copy link
Contributor

I believe @bcoe was looking into this. Did you have nay progress?

@addaleax
Copy link
Member

@thealphanerd as far as yargs is concerned, yargs/yargs#597 should take care of it. Having pty support in citgm might be still nice to have, though.

@Fishrock123
Copy link
Contributor

Fishrock123 commented Aug 22, 2016

Having some sort of instruction to use pty.js instead of the regular stdio options when spawning a new process is probably all that is needed here?

Unfortunately I think most people don't even know about that sort of difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants