Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I use the local built headers to build native? #2689

Closed
jrgleason opened this issue May 9, 2020 · 5 comments
Closed

How do I use the local built headers to build native? #2689

jrgleason opened this issue May 9, 2020 · 5 comments

Comments

@jrgleason
Copy link

  • 15.0.0-pre:
  • OSX:
  • Headers (node-v15.0.0-pre-headers.tar.gz):

I am building node from source like this...

./configure --release-urlbase=/.../Code/node
make DISTTYPE=custom CUSTOMTAG=pre tar-headers
make
make install

When I run node -p process.release I see...

{
  name: 'node',
  sourceUrl: '/.../Code/nodev15.0.0-pre/node-v15.0.0-pre.tar.gz',
  headersUrl: '/.../Code/nodev15.0.0-pre/node-v15.0.0-pre-headers.tar.gz'
}

But when I run npm install I get...

info DIST Downloading distribution files.
http DIST       - https://nodejs.org/dist/v15.0.0-pre/SHASUMS256.txt
http DIST       - https://nodejs.org/dist/v15.0.0-pre/node-v15.0.0-pre-headers.tar.gz
ERR! OMG Error: incorrect header check
ERR! OMG     at Zlib.zlibOnError [as onerror] (zlib.js:180:17)
ERR! OMG Error: incorrect header check
ERR! OMG     at Zlib.zlibOnError [as onerror] (zlib.js:180:17)
npm ERR! code ELIFECYCLE
npm ERR! errno 1

What am I missing?

@bnoordhuis
Copy link
Member

No surprise, they need to be actual URLs. Litmus test: if url.resolve() won't accept it, then neither will node-gyp.

I'm closing this but let me know if you have follow-up questions.

@bnoordhuis
Copy link
Member

Let me trim that down to just "need to be actual URLs" - url.resolve() is notoriously forgiving in what it accepts, hence why it was superseded by the URL class. :-)

The tl;dr: must be HTTP or HTTPS URLs.

@bnoordhuis
Copy link
Member

And sorry about closing, I thought this was posted in nodejs/node-gyp for some reason.

@bnoordhuis bnoordhuis reopened this May 11, 2020
@gireeshpunathil
Copy link
Member

@jrgleason - is this resolved?

@gireeshpunathil
Copy link
Member

closing as answered, pls reopen if you still have issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants