Skip to content
This repository has been archived by the owner on Jul 6, 2018. It is now read-only.

setHeader is an hot function #27

Closed
mcollina opened this issue Dec 9, 2016 · 2 comments
Closed

setHeader is an hot function #27

mcollina opened this issue Dec 9, 2016 · 2 comments

Comments

@mcollina
Copy link
Member

mcollina commented Dec 9, 2016

Currently we cross the JS/C++ boundary quite a lot in setHeader, and we cause some mallocs. Can we avoid that, or make it less of an issue? Maybe we can batch the headers, and pass them down all together before starting the reply.
schermata 2016-12-09 alle 11 54 46
@jasnell
Copy link
Member

jasnell commented Dec 9, 2016

Yes, I'm planning on refactoring this entire bit next week.

@mcollina
Copy link
Member Author

mcollina commented Mar 4, 2017

This should be fixed.

@mcollina mcollina closed this as completed Mar 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @jasnell