Skip to content

Commit

Permalink
smalloc: deprecate whole module
Browse files Browse the repository at this point in the history
It makes no sense to allow people use constants from
`smalloc`, since it will be removed completely eventually.

PR-URL: #1822
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
vkurchatkin committed Jun 4, 2015
1 parent 628845b commit 6d95f4f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 27 deletions.
2 changes: 1 addition & 1 deletion lib/fs.js
Expand Up @@ -19,7 +19,7 @@ const Readable = Stream.Readable;
const Writable = Stream.Writable;

const kMinPoolSpace = 128;
const kMaxLength = require('smalloc').kMaxLength;
const kMaxLength = require('internal/smalloc').kMaxLength;

const O_APPEND = constants.O_APPEND || 0;
const O_CREAT = constants.O_CREAT || 0;
Expand Down
3 changes: 1 addition & 2 deletions lib/repl.js
Expand Up @@ -61,8 +61,7 @@ exports.writer = util.inspect;
exports._builtinLibs = ['assert', 'buffer', 'child_process', 'cluster',
'crypto', 'dgram', 'dns', 'domain', 'events', 'fs', 'http', 'https', 'net',
'os', 'path', 'punycode', 'querystring', 'readline', 'stream',
'string_decoder', 'tls', 'tty', 'url', 'util', 'v8', 'vm', 'zlib',
'smalloc'];
'string_decoder', 'tls', 'tty', 'url', 'util', 'v8', 'vm', 'zlib'];


const BLOCK_SCOPED_ERROR = 'Block-scoped declarations (let, ' +
Expand Down
27 changes: 3 additions & 24 deletions lib/smalloc.js
@@ -1,27 +1,6 @@
'use strict';

const smalloc = require('internal/smalloc');
const deprecate = require('util').deprecate;
const util = require('internal/util');

exports.alloc =
deprecate(smalloc.alloc, 'smalloc.alloc: Deprecated, use typed arrays');

exports.copyOnto =
deprecate(smalloc.copyOnto,
'smalloc.copyOnto: Deprecated, use typed arrays');

exports.dispose =
deprecate(smalloc.dispose,
'smalloc.dispose: Deprecated, use typed arrays');

exports.hasExternalData =
deprecate(smalloc.hasExternalData,
'smalloc.hasExternalData: Deprecated, use typed arrays');

Object.defineProperty(exports, 'kMaxLength', {
enumerable: true, value: smalloc.kMaxLength, writable: false
});

Object.defineProperty(exports, 'Types', {
enumerable: true, value: Object.freeze(smalloc.Types), writable: false
});
module.exports = require('internal/smalloc');
util.printDeprecationMessage('smalloc is deprecated.');

0 comments on commit 6d95f4f

Please sign in to comment.