Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borked libuv 1.4.2 update #1621

Closed
19h opened this issue May 5, 2015 · 10 comments
Closed

Borked libuv 1.4.2 update #1621

19h opened this issue May 5, 2015 · 10 comments
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.

Comments

@19h
Copy link
Contributor

19h commented May 5, 2015

Hey,

having trouble with libuv shipping alongside iojs.

I expected b2a0d8f to land libuv/libuv@252f362 which resides in libuv since March 18 (https://github.com/libuv/libuv/blob/v1.x/include/uv.h#L646-L654).

But then I noticed that 1.4.2 was tagged way before the landing (February 25). That is, could you please both tag libuv 1.4.3 and land it?

Relevant cross-issue: FrontierPsychiatrist/node-spotify#93 (comment)

cc @indutny @saghul
@indutny
Copy link
Member

indutny commented May 5, 2015

@saghul: we need a release to update it ;)

@saghul
Copy link
Member

saghul commented May 5, 2015

I plan to release libuv 1.5.0 tonight / tomorrow morning.

@mscdex mscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 5, 2015
@Fishrock123
Copy link
Member

Awesome. When you make the PR I'll go through the issues and find the bunch we have that should be fixed by 1.5.0.

@Fishrock123 Fishrock123 mentioned this issue May 5, 2015
Closed
@rvagg
Copy link
Member

rvagg commented May 5, 2015

@Fishrock123 why are you thinking this should be semver-minor?

@Fishrock123
Copy link
Member

I think @bnoordhuis said in irc it would be 2.1? if it's not that's also cool.

@ChALkeR ChALkeR mentioned this issue May 6, 2015
Closed
bnoordhuis pushed a commit that referenced this issue May 6, 2015
@saghul @bnoordhuis
deps: update libuv to 1.5.0
04cc03b 
Fixes: #1397
Fixes: #1512
Fixes: #1621
Fixes: #862
PR-URL: #1646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Should be fixed by 04cc03b. Closing, holler if I should reopen it.

@jbergstroem
Copy link
Member

Since this doesn't seem to touch anything else but deps/ I don't really see why it would warrant a semver-minor.

@19h
Copy link
Contributor Author

19h commented May 7, 2015

Great, thanks everyone! 🍻

@bnoordhuis
Copy link
Member

@jbergstroem libuv is a public and supported part of the API in the sense that add-ons build and link against it.

There haven't been API additions in v1.5.0 so perhaps io.js can get away with a patchlevel bump but that's a little awkward to explain.

@jbergstroem
Copy link
Member

@bnoordhuis ah, of course.

Fishrock123 pushed a commit to Fishrock123/node that referenced this issue May 19, 2015
@saghul @Fishrock123
deps: update libuv to 1.5.0
8651ecc 
Fixes: nodejs#1397
Fixes: nodejs#1512
Fixes: nodejs#1621
Fixes: nodejs#862
PR-URL: nodejs#1646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mscdex @jbergstroem @indutny @bnoordhuis @19h @saghul @rvagg @Fishrock123