configure: use gcc and g++ as CC and CXX defaults #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It matches what GYP's Makefile generator does and it should improve compiler detection because cc and c++ are not always gcc and g++. Fixes: nodejs#1173 PR-URL: nodejs#1174 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
I think this is the right move. LGTM. |
bnoordhuis
force-pushed
the
change-cc-cxx-defaults
branch
from
fa52db6
to
8b2363d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It matches what GYP's Makefile generator does and it should improve
compiler detection because cc and c++ are not always gcc and g++.
Fixes: #1173
R=@Fishrock123