js2c: fix module id generation on windows #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm off to bed so someone please land this if it LGTY and the CI is happy. |
|
LGTM if CI is ok. I'm wondering how it compiles with an empty string as a module name. |
|
I think CI is ok. Not familiar with smartos failure, but seems unrelated. Timeouts: also probably not related (to this or the original commit). |
|
Yeah, smartos is unrelated. |
mscdex
added
windows
Fix a regression that was introduced in commit 2db758c ("iojs: introduce
internal modules") where the computed id for "config.gypi" on Windows
was not "config" but an empty string.
With an empty string, the build succeeds but the binary is unusable:
startup.processConfig() in src/node.js chokes on the missing .config
property.
PR-URL: nodejs#1281
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
bnoordhuis
force-pushed
the
windows-build-bug
branch
from
fd6c587
to
36f017a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression that was introduced in commit 2db758c ("iojs: introduce
internal modules") where the computed id for "config.gypi" on Windows
was not "config" but an empty string.
With an empty string, the build succeeds but the binary is unusable:
startup.processConfig() in src/node.js chokes on the missing .config
property.
R=@vkurchatkin
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/385/