build: Simplify fetching release version #1405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -197,7 +197,7 @@ docclean: | |||
| RAWVER=$(shell $(PYTHON) tools/getnodeversion.py) | |||
| VERSION=v$(RAWVER) | |||
| FULLVERSION=$(VERSION) | |||
| RELEASE=$(shell $(PYTHON) tools/getnodeisrelease.py) | |||
| RELEASE=($shell grep "#define NODE_VERSION_IS_RELEASE" src/node_version.h | sed 's/[^0-9]//g') | |||
There was a problem hiding this comment.
This can be shortened to sed -ne 's/#define NODE_VERSION_IS_RELEASE \([01]\)/\1/p' src/node_version.h
|
LGTM with a suggestion. |
|
lgtm |
jbergstroem
added a commit
that referenced
this pull request
Apr 13, 2015
PR-URL: #1405 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
|
Fixed in f9a2d31. Thanks for the review. |
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Apr 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling python for something we can do in grep/sed (we're already avid users of said tools).