-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: fix legacy SNICallback #1720
Conversation
cc @socketpair |
mkey, what about tests :) ? |
You actually already wrote one :) Haha. |
@bnoordhuis cc |
@indutny Can you add a regression test? Maybe use Aside, is there a reason for the existence of |
`onselect` is set on the `sniObject_` not on the `Connection` instance. See: nodejs/node-v0.x-archive#25109 PR-URL: nodejs#1720 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
79d647d
to
0f2a9f8
Compare
Added a test, running CI. |
`onselect` is set on the `sniObject_` not on the `Connection` instance. See: nodejs/node-v0.x-archive#25109 PR-URL: #1720 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Landed in eb35968, thank you everyone! |
onselect
is set on thesniObject_
not on theConnection
instance.See: nodejs/node-v0.x-archive#25109