node: mark promises as handled as soon as possible #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -275,6 +275,20 @@ asyncTest('Attaching a promise catch in a process.nextTick is soon enough to' + | |||
| }); | |||
| }); | |||
|
|
|||
| asyncTest('Some weird edge-case', function(done) { | |||
There was a problem hiding this comment.
Have no idea how to describe this test case
There was a problem hiding this comment.
While inside setImmediate, catching a rejected promise derived from returning a rejected promise in a fulfillment handler prevents unhandledRejection
|
LGTM with nit/name changes assuming all existing tests still pass. This is pretty delicate logic but also quite well-tested :) |
|
LGTM |
| @@ -275,6 +275,20 @@ asyncTest('Attaching a promise catch in a process.nextTick is soon enough to' + | |||
| }); | |||
| }); | |||
|
|
|||
| asyncTest('Some weird edge-case', function(done) { | |||
| var e = new Error(); | |||
Fixes: nodejs#1912 PR-URL: nodejs#1952 Reviewed-By: Domenic Denicola <d@domenic.me> Reviewed-By: Petka Antonov <petka_antonov@hotmail.com>
vkurchatkin
force-pushed
the
fix-unhandled-rejection
branch
from
d57ea88
to
a251657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1912
R=@petkaantonov